On Wed, Jul 2, 2025 at 5:37 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Wed, Jul 02, 2025 at 10:43:24AM +0530, Anup Patel wrote:
> > Add defines for the new SBI message proxy extension which is part
> > of the SBI v3.0 specification.
>
> Actually a few nit-picks.
>
> ...
>
> > +enum sbi_ext_mpxy_fid {
> > + SBI_EXT_MPXY_GET_SHMEM_SIZE,
> > + SBI_EXT_MPXY_SET_SHMEM,
> > + SBI_EXT_MPXY_GET_CHANNEL_IDS,
> > + SBI_EXT_MPXY_READ_ATTRS,
> > + SBI_EXT_MPXY_WRITE_ATTRS,
> > + SBI_EXT_MPXY_SEND_MSG_WITH_RESP,
> > + SBI_EXT_MPXY_SEND_MSG_WITHOUT_RESP,
> > + SBI_EXT_MPXY_GET_NOTIFICATION_EVENTS
>
> Add a trailing comma.
Okay, I will update.
>
> > +};
>
> ...
>
> > +/* Possible values of MSG_PROT_ID attribute */
> > +enum sbi_mpxy_msgproto_id {
> > + SBI_MPXY_MSGPROTO_RPMI_ID = 0x0
>
> Add a trailing comma, and you might want to drop 0x. I don't know what else can
> be here, esp. in the future, but some kind of the description of this in TRM
> can shed a light on what is better pattern to use.
Sure, I will update.
Regards,
Anup
