On Wed, Jul 02, 2025 at 10:43:42AM +0530, Anup Patel wrote: > From: Sunil V L <sunilvl@xxxxxxxxxxxxxxxx> > > Add ACPI support for the RISC-V SBI message proxy (MPXY) based > mailbox driver. ... > - if (dev_of_node(dev)) > + if (is_of_node(fwnode)) { > of_msi_configure(dev, dev_of_node(dev)); > + } else if (is_acpi_device_node(fwnode)) { > + msi_domain = irq_find_matching_fwnode(imsic_acpi_get_fwnode(dev), > + DOMAIN_BUS_PLATFORM_MSI); > + dev_set_msi_domain(dev, msi_domain); > + } Actually you don't need to have the if-else-if if I am not mistaken. The OF does almost the same as it's done in the second branch for ACPI case. How many MSI parents this may have? -- With Best Regards, Andy Shevchenko