On Thu, Jun 05, 2025 at 05:52:59PM +0000, Ricardo Ribalda wrote: > For some devices, such as cameras, the OS needs to know where they are > mounted. > > ACPI has a property for this purpose, which is parsed by > acpi_get_physical_device_location(): > https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/06_Device_Configuration/Device_Configuration.html#pld-physical-location-of-device > > In DT we have similar properties for video-interface-devices called > orientation and rotation: > Documentation/devicetree/bindings/media/video-interface-devices.yaml > > Add rotation and orientation for usb-devices that matches the already > existing properties of video-interface-devices. > > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/usb/usb-device.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) Comments from v1 still apply. Add a schema for *your* device (i.e. one that only matches the compatible string of your device). Look for anything that includes usb-device.yaml for an example. Your schema should have something like this if you want to use video-interface-devices.yaml properties: allOf: - $ref: /schemas/usb/usb-device.yaml# - $ref: /schemas/media/video-interface-devices.yaml# > > diff --git a/Documentation/devicetree/bindings/usb/usb-device.yaml b/Documentation/devicetree/bindings/usb/usb-device.yaml > index c676956810331b81f11f3624340fc3e612c98315..a44eb24c657993f88145377a4706ec419b6cd998 100644 > --- a/Documentation/devicetree/bindings/usb/usb-device.yaml > +++ b/Documentation/devicetree/bindings/usb/usb-device.yaml > @@ -44,6 +44,14 @@ properties: > - minimum: 1 > maximum: 255 > > + orientation: > + description: If present, specifies the orientation of the usb device. > + $ref: /schemas/media/video-interface-devices.yaml#/properties/orientation Again, this is generally the wrong way to add properties from another schema for your device. Above is the right way. Rob
