On Wed, Jun 25, 2025 at 12:31:10AM +0300, Dan Carpenter wrote: > On Tue, Jun 24, 2025 at 09:29:37PM +0100, Colin Ian King wrote: > > In the case where a request_mem_region call fails and pointer r is null > > the error exit path via label 'out' will check for a non-null pointer > > p and try to iounmap it. However, pointer p has not been assigned a > > value at this point, so it may potentially contain any garbage value. > > Fix this by ensuring pointer p is initialized to NULL. > > > > Fixes: 1a35c88302a3 ("ACPI: APEI: EINJ: Fix kernel test sparse warnings") > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> > > --- > > Good catch. Apparently this isn't in my allyesconfig. It's weird the > zero day bot didn't catch this either. Never mind. This is definitely in my allyesconfig. regards, dan carpenter