On Fri, Jun 20, 2025 at 12:30:37PM +0100, Igor Korotin wrote: > Just to make sure that we're on the same page, I replace this: > > if dev.fwnode().is_some_and(|node| > node.is_compatible(c_str!("test,rust-device"))) > > with: > > if dev.fwnode().is_some_and(|node| node.is_of_node()) > > And reworded the comment as follows: > > samples: rust: platform: conditionally call Self::properties_parse() > > Only call Self::properties_parse() when the device is OF node > > Once we add ACPI support, we don't want the ACPI device to fail probing > in Self::properties_parse(). LGTM!