On Fri, Jun 13, 2025 at 02:13:49PM -0700, Saravana Kannan wrote: > On Fri, Jun 13, 2025 at 6:49 AM Herve Codina <herve.codina@xxxxxxxxxxx> wrote: > > Setting fwnode->dev is specific to fw_devlink. > > > > In order to avoid having a direct 'fwnode->dev = dev;' in several > > place in the kernel, introduce fw_devlink_set_device() helper to perform > > this operation. > > This should not be set anywhere outside the driver core files. I'll > get to reviewing the series Strictly speaking I agree with you, but this is not a some driver case, it's very special and also we have some (ab)users of it. I can relax the requirement to not set outside of a core functionality, (like driver core, PCI core) which are tightly related to driver core one. Just my 2c. -- With Best Regards, Andy Shevchenko
