> Alternatively, if you want to upstream this dependency already you can send the > following patches: > > - this acpi::DeviceId abstraction > - the glue code for the generic adapter trait in rust/kernel/driver.rs > - use this glue code in the platform abstraction > - add acpi support to the platform sample driver > > This way we can already validate that the code works correctly. All this is > required anyways if the I2C device you write a driver for is on the platform > bus. A few questions if I may: 1. I committed to 4 different files: `acpi.rs`, `driver.rs`, `platform.rs`, platform rust sample driver. Should I commit all of this as one commit or split each part to a separate commit and send it as a patch sequence? 2. From author's point of view, as Danilo noticed, `acpi table` abstraction code is in general just copy-paste from `of table` abstraction code. How should I explicitly mark that fact? Thanks Igor
