RE: [PATCH v5 1/3] ACPI/MRRM: Minimal parse of ACPI MRRM table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/drivers/acpi/acpi_mrrm.c b/drivers/acpi/acpi_mrrm.c
> new file mode 100644
> index 000000000000..ab8022e58da5
> --- /dev/null
> +++ b/drivers/acpi/acpi_mrrm.c
> @@ -0,0 +1,42 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2025, Intel Corporation.
> + *
> + * Memory Range and Region Mapping (MRRM) structure
> + */
> +
> +#define pr_fmt(fmt) "acpi/mrrm: " fmt
> +
> +#include <linux/acpi.h>
> +#include <linux/init.h>
> +
> +static int max_mem_region = -ENOENT;
> This should be initialized to 1 instead of -ENOENT(-2).
> Per the spec, sec 5.1, if platform does not define MRRM, it says, SW may assume that only one memory region is defined.
>
> +
> +/* Access for use by resctrl file system */
> +int acpi_mrrm_max_mem_region(void)
> +{
> +     return max_mem_region;
> +}
> In which case this function will return a minimum of 1 region as max_mem_region of -2 has no meaning.
> When resctrl file system calls this function, it expects at least one region exists.

[Replying to HTML e-mail that will have been dropped from LKML and other lists]

Anil,

Rafael has this queued for next merge window. Please send a patch to
fix the issues you found.

Thanks

-Tony




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux