On Tue, 20 May 2025 11:37:13 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 20 May 2025 11:11:24 -0700 Joshua Hahn <joshua.hahnjy@xxxxxxxxx> wrote: > > > > Honggyu's Reviewed-by is the only change I'm seeing between v8 and v9, > > > which is unexpected? > > > > > > > Hello Andrew, > > > > The code cleanups & wordsmithing were part of the fixlets that I submitted, > > so if you are diffing against the version of v8 with the fixlets already in, > > all you should see as diffs are Honggyu's review and test tag, as well as > > Ying's review tag. > > > > I was not very familiar with the fixlet process, so I imagined that I needed > > so submit a new fixlet to add the 3 tags. If that is not the case (and you > > can just change the tags without adding a new fixlet) perhaps we can keep > > v8, just with the additional tags so we can keep the patch in the unstable > > branch? > > Yes, while the patch is in mm-unstable I frequently update changelogs as > acks come in, as people provide testing results etc etc. Ah I see, sorry for the confusion in that case. Then I think all that should change is to add Honggyu's review / tested-by tags to the changelog: Co-developed-by: Gregory Price <gourry@xxxxxxxxxx> Signed-off-by: Gregory Price <gourry@xxxxxxxxxx> Signed-off-by: Joshua Hahn <joshua.hahnjy@xxxxxxxxx> Suggested-by: Yunjeong Mun <yunjeong.mun@xxxxxx> Suggested-by: Oscar Salvador <osalvador@xxxxxxx> Suggested-by: Ying Huang <ying.huang@xxxxxxxxxxxxxxxxx> Suggested-by: Harry Yoo <harry.yoo@xxxxxxxxxx> Reviewed-by: Harry Yoo <harry.yoo@xxxxxxxxxx> Reviewed-by: Huang Ying <ying.huang@xxxxxxxxxxxxxxxxx> +Reviewed-by: Honggyu Kim <honggyu.kim@xxxxxx> +Tested-by: Honggyu Kim <honggyu.kim@xxxxxx> Thank you for your help as always, have a great day! Joshua