On Wed, May 07, 2025 at 09:12:50AM +0200, Herve Codina wrote: > The code set directly fwnode->dev field. > > Use the dedicated fw_devlink_set_device() helper to perform this > operation. ... > fwnode = fwnode_get_named_child_node(fwnode, "pinctrl"); > > if (fwnode && !fwnode->dev) Why do we bother checking the fwnode->dev here? Just wondering... Hopefully the original author of the code can explain what is going on here. > - fwnode->dev = priv->dev; > + fw_devlink_set_device(fwnode, priv->dev); > } -- With Best Regards, Andy Shevchenko
