On Thu, May 1, 2025 at 2:53 PM Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
>
> On Thu, May 01, 2025 at 01:46:21PM +0100, Jon Hunter wrote:
> > Commit 6cb9441bfe8d ("ACPI: APEI: EINJ: Transition to the faux device
> > interface") updated the APEI error injection driver to use the faux
> > device interface and now for devices that don't support ACPI, the
> > following error message is seen on boot:
> >
> > ERR KERN faux acpi-einj: probe did not succeed, tearing down the device
> >
> > The APEI error injection driver returns -ENODEV in the probe function
> > if ACPI is not supported and so after transitioning the driver to the
> > faux device interface, the error returned from the probe now causes the
> > above error message to be displayed.
> >
> > Fix this by moving the code that detects if ACPI is supported to the
> > einj_init() function to fix the false error message displayed for
> > devices that don't support ACPI.
> >
>
> Good catch, it was silently passing error before.
>
> Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx>
Applied, thanks!
That said, when fixing a bug that is only present in linux-next and
not yet in the mainline, I'd appreciate a note about this, especially
if it carries a Fixes: tag, because I do rebase patches occasionally
and the commit ids may get stale.
