On Wed, May 07, 2025 at 01:44:26PM +0200, Rafael J. Wysocki wrote: > On Wed, May 7, 2025 at 1:40 PM Sudeep Holla <sudeep.holla@xxxxxxx> wrote: > > > > On Wed, May 07, 2025 at 11:51:24AM +0800, Yicong Yang wrote: > > > From: Yicong Yang <yangyicong@xxxxxxxxxxxxx> > > > > > > Below error is met on my board and QEMU VM on SMT or non-SMT machine: > > > ACPI PPTT: PPTT table found, but unable to locate core 31 (31) > > > > > > This is because the processor node is found by iterating the PPTT > > > table under condition (for both acpi_find_processor_node() and > > > acpi_pptt_leaf_node()): > > > while (entry + proc_sz < table_end) > > > [parse the processor node] > > > > > > If the last processor node is happened to be the last node in the > > > PPTT table, above condition will always be false since > > > entry + proc_sz == table_end. Thus the last CPU is not parsed. > > > Fix the loop condition to resolve the issue. > > > > > > This issue is exposed by [1] but the root cause is explained above. > > > Before [1] entry + proc_sz is always smaller than table_end. > > > > > > > Another thread [1] with similar patch. > > OK, so is this a correct fix? While it may fix the issue on the surface, I just want to be sure there are no other issues with the PPTT table presented from the firmware. I will asked some questions on that thread before I can agree on the solution. -- Regards, Sudeep
