On Thu, Apr 17, 2025 at 2:59 PM Mario Limonciello <superm1@xxxxxxxxxx> wrote: > > On 4/17/2025 7:46 AM, Rafael J. Wysocki wrote: > > On Thu, Apr 17, 2025 at 2:03 PM Mario Limonciello <superm1@xxxxxxxxxx> wrote: > >> > >> > >> > >> On 4/17/25 06:19, Rafael J. Wysocki wrote: > >>> On Thu, Apr 17, 2025 at 5:10 AM Mario Limonciello <superm1@xxxxxxxxxx> wrote: > >>>> > >>>> From: Mario Limonciello <mario.limonciello@xxxxxxx> > >>>> > >>>> When debug level is set to `ACPI_LV_TRACE_POINT` method start and > >>>> exit are emitted into the debug logs. This can be useful to understand > >>>> call paths, however none of the arguments for the method calls are > >>>> populated even when turning up other debug levels. > >>>> > >>>> This can be useful for BIOSes that contain debug strings to see those > >>>> strings. When `ACPI_LV_TRACE_POINT` is set also output all of the arguments > >>>> for a given method call. > >>>> > >>>> This enables this type of debugging: > >>>> > >>>> ``` > >>>> extrace-0138 ex_trace_point : Method Begin [0x0000000096b240c4:\M460] execution. > >>>> extrace-0173 ex_trace_args : " POST CODE: %X ACPI TIMER: %X TIME: %d.%d ms\n", b0003f53, 1a26a8b2, 0, 15e, 0, 0 > >>>> extrace-0138 ex_trace_point : Method End [0x0000000096b240c4:\M460] execution. > >>>> ``` > >>>> > >>>> Link: https://github.com/acpica/acpica/commit/08219d91b5678ae2fae6e4f208df790a4e108c1c > >>> > >>> The link doesn't work. > >> > >> Are you sure? > >> > >> I just tried again and it worked for me. > > > > Yeah, it works now, I had to sign in to github. > > > > But it is a link to a commit and I need a link to a PR. I think it's this one: > > > > https://github.com/acpica/acpica/pull/1012 > > Yes that's the right PR that led to the commit. Can you swap it out? Yes, I can. > Or would you like me to resubmit with it adjusted? No need. Thanks!
