On Wed, Apr 9, 2025 at 9:25 PM Sudeep Holla <sudeep.holla@xxxxxxx> wrote: > > On Thu, Apr 10, 2025 at 02:10:04AM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge > > head: 089d4e79e2c932faef79e0061cb874000f755009 > > commit: 4ec052af63c58a62a896508cc5f8a0a2f516a590 [39/52] ACPI: APEI: EINJ: Transition to the faux device interface > > config: x86_64-buildonly-randconfig-001-20250409 (https://download.01.org/0day-ci/archive/20250410/202504100128.AjbVDQgK-lkp@xxxxxxxxx/config) > > compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250410/202504100128.AjbVDQgK-lkp@xxxxxxxxx/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202504100128.AjbVDQgK-lkp@xxxxxxxxx/ > > > > All errors (new ones prefixed by >>): > > > > >> drivers/acpi/apei/einj-core.c:877:43: error: expected identifier > > 877 | module_faux_driver(acpi_einj, einj_probe, __exit_p(einj_remove), true); > > | ^ > > include/linux/init.h:397:21: note: expanded from macro '__exit_p' > > 397 | #define __exit_p(x) NULL > > | ^ > > include/linux/stddef.h:8:14: note: expanded from macro 'NULL' > > 8 | #define NULL ((void *)0) > > | ^ > > >> drivers/acpi/apei/einj-core.c:877:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int] > > 877 | module_faux_driver(acpi_einj, einj_probe, __exit_p(einj_remove), true); > > | ^ > > | int > > >> drivers/acpi/apei/einj-core.c:877:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] > > 877 | module_faux_driver(acpi_einj, einj_probe, __exit_p(einj_remove), true); > > | ^ > > | void > > 3 errors generated. > > > > > > vim +877 drivers/acpi/apei/einj-core.c > > > > 876 > > > 877 module_faux_driver(acpi_einj, einj_probe, __exit_p(einj_remove), true); > > 878 > > > > The macro module_faux_driver() was not merged as most of the users I > posted in v2 of the series depend on modprobe and modalias and that > doesn't work with faux devices. > > If this ACPI APEI EINJ also needs that support we can't use faux device. > But I think this doesn't have modalias, so v1 of this change[1] which > doesn't introduce/use the macro module_faux_driver() can be used instead. > > Sorry for the noise with v2. No worries. I've picked up the v1 instead, let's see how it goes. > [1] https://lore.kernel.org/all/20250317-plat2faux_dev-v1-8-5fe67c085ad5@xxxxxxx/
