On 4/8/25 09:00, Rob Herring wrote: > On Mon, Apr 7, 2025 at 5:37 PM Sean Anderson <sean.anderson@xxxxxxxxx> wrote: >> >> Add a fwnode variant of of_parse_phandle_with_optional_args to allow >> nargs_prop to be absent from the referenced node. This improves >> compatibility for references where the devicetree might not always have >> nargs_prop. > > Can't we just make fwnode_property_get_reference_args() handle this > case? Or why is it not just a 1 line wrapper function? fwnode_property_get_reference_args ignores nargs when nargs_prop is non-NULL. So all the existing callers just pass 0 to nargs. Rather than convert them, I chose to add another function with different defaults. There are only four callers that pass nargs_prop, so I could just as easily change the callers instead. --Sean