On Mon, Apr 07, 2025 at 08:44:20PM +0200, Rafael J. Wysocki wrote: > On Mon, Apr 7, 2025 at 8:36 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Mon, Apr 07, 2025 at 08:17:17PM +0200, Rafael J. Wysocki wrote: > > > On Mon, Mar 31, 2025 at 6:32 PM Andy Shevchenko > > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > > > > > Add a note to the fwnode.h that the header should not be used > > > > directly in the leaf drivers, they all should use the higher > > > > level APIs and the respective headers. > > > > > > This sounds like a solution to a problem, but the problem statement is missing. > > > > > What's your motivation? > > > > Found a few drivers that are mistakenly include fwnode.h while they meant to > > have either of.h or more likely property.h. > > I see. > > I would then say > > "This header file provides low-level data types and definitions for > firmware and device property providers. The respective API header > files supplied by them should contain all of the requisite data types > and definitions for end users, so including it directly should not be > necessary." > > And I would mention that the purpose is to give guidance to driver > writers to avoid repeating a common mistake. A-ha, thanks for the suggestion, since there is also a v2, which almost the same, I will incorporate it into v3. -- With Best Regards, Andy Shevchenko
