On Thu, Apr 03, 2025 at 01:57:22PM +0200, Bartosz Golaszewski wrote: > On Thu, Apr 3, 2025 at 1:04 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Thu, Apr 03, 2025 at 01:35:06PM +0300, Mika Westerberg wrote: > > > On Wed, Apr 02, 2025 at 03:21:19PM +0300, Andy Shevchenko wrote: > > > > Some of the contents of struct acpi_gpio_lookup repeats what we have > > > > in the struct acpi_gpio_params. Reuse the latter in the former. > > > > > > + struct acpi_gpio_params par; > > > > > > params is better name > > > > It's been already used elsewhere in the code. Do you want renaming there as > > well for consistency's sake? > > +1 for using param or params here and elsewhere. It's much better than par. Okay, will be an add-on in the next version. But I will wait for Mika and others to review the rest and give tags and/or comments where it applies. -- With Best Regards, Andy Shevchenko
