On Thu, Mar 27, 2025 at 3:37 AM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Wed, Mar 26, 2025 at 06:13:40PM +0100, Remo Senekowitsch wrote: > > Not all property-related APIs can be exposed directly on a device. > > For example, iterating over child nodes of a device will yield > > fwnode_handle. Thus, in order to access properties on these child nodes, > > the APIs has to be duplicated on a fwnode as they are in C. > > > > A related discussion can be found on the R4L Zulip[1]. > > > > [1] https://rust-for-linux.zulipchat.com/#narrow/channel/288089-General/topic/DS90UB954.20driver.20done.2C.20ready.20to.20upstream.3F/near/505415697 > > You can make the above to be a Link tag like > > Link: ... [1] > > > Signed-off-by: Remo Senekowitsch <remo@xxxxxxxxxxx> > > ... > > > +struct fwnode_handle *rust_helper_dev_fwnode(struct device *dev) > > +{ > > + return dev_fwnode(dev); > > +} > > Why not const? For most of the property retrieval APIs the parameter is const. Because you might need to modify the refcount. Though the rust code should probably use __dev_fwnode() and/or __dev_fwnode_const() directly and avoid the need for the helper here. Rob
