shiju.jose@ wrote: > From: Shiju Jose <shiju.jose@xxxxxxxxxx> > > Add helper function to retrieve a feature entry from the supported > features list, if supported. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Reviewed-by: Fan Ni <fan.ni@xxxxxxxxxxx> > Signed-off-by: Shiju Jose <shiju.jose@xxxxxxxxxx> > --- > drivers/cxl/core/core.h | 2 ++ > drivers/cxl/core/features.c | 23 +++++++++++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h > index 1803aedb25ca..16bc717376fc 100644 > --- a/drivers/cxl/core/core.h > +++ b/drivers/cxl/core/core.h > @@ -123,6 +123,8 @@ int cxl_ras_init(void); > void cxl_ras_exit(void); > > #ifdef CONFIG_CXL_FEATURES > +struct cxl_feat_entry *cxl_get_feature_entry(struct cxl_dev_state *cxlds, > + const uuid_t *feat_uuid); It is unfortunate that this naming choice is too similar to cxl_get_feature(). However, as I go to suggest a new name I find that this is a duplicate of get_support_feature_info() in Dave's fwctl series. Just drop this patch in favor of that.