On Tue Mar 25, 2025 at 4:36 PM -03, Armin Wolf wrote: > Am 22.03.25 um 22:03 schrieb Kurt Borja: > >> Choices aggregates passed to _aggregate_choices() are already filled >> with ones, therefore we can avoid copying a new bitmap on the first >> iteration. >> >> This makes setting the PLATFORM_PROFILE_LAST bit on aggregates >> unnecessary, so drop it as well. >> >> While at it, add a couple empty lines to improve style. >> > Please add a comment to signal future developers that the bitmap needs to be filled with ones > before being passed to _aggregate_choices(). Sure, I'll mention it in the kernel-doc for v2. > > With this being addressed: > > Reviewed-by: Armin Wolf <W_Armin@xxxxxx> Thank you Mario and Armin for the reviews! -- ~ Kurt
