On Tue, Aug 19, 2025 at 6:56 AM <fangyu.yu@xxxxxxxxxxxxxxxxx> wrote: > > >> > >> From: Fangyu Yu <fangyu.yu@xxxxxxxxxxxxxxxxx> > >> > >> Currently we use kvm_riscv_gstage_ioremap to map IMSIC gpa to the spa of > >> guest interrupt file within IMSIC. > >> > >> The PAGE_KERNEL_IO property does not include user mode settings, so when > >> accessing the IMSIC address in the virtual machine, a guest page fault > >> will occur, this is not expected. > >> > >> According to the RISC-V Privileged Architecture Spec, for G-stage address > >> translation, all memory accesses are considered to be user-level accesses > >> as though executed in Umode. > >> > >> Signed-off-by: Fangyu Yu <fangyu.yu@xxxxxxxxxxxxxxxxx> > > > >Overall, a good fix. Thanks! > > > >The patch subject and description needs improvements. Also, there is no > >Fixes tag which is required for backporting. > > > >I have taken care of the above things at the time of merging this patch. > > > >Queued this patch as fixes for Linux-6.17 > > > >Thanks, > >Anup > > > > Thanks for your review. > I will send a v2 patch to fix these comments. No need, it's already part of my riscv_kvm_fixes branch at: https//github.com/kvm-riscv/linux.git Regards, Anup
