On Wed, Aug 20, 2025, Nikunj A. Dadhania wrote: > On 8/20/2025 4:55 PM, Huang, Kai wrote: > > On Wed, 2025-08-20 at 14:18 +0530, Nikunj A. Dadhania wrote: > >>> - Continue on with snp_launch_start() if default_tsc_khz is '0'. AFAICT, > >>> continuing on doesn't put the host at (any moer) risk. [Kai] > >> > >> If I hack default_tsc_khz as '0', SNP guest kernel with SecureTSC spits out > >> couple of warnings and finally panics: > >> > > > > It's a surprise that the SEV_CMD_SNP_LAUNCH_START didn't fail in such > > configuration. :-) > > As mentioned here[1], this is an unsupported configuration as per the SNP > Firmware ABI. Yeah, but outside of AMD hardware/firmware, the usual response to an unsupported configuration is to return an error :-D Anyways, I'll fixup to the -EINVAL version from v10 when applying.
