On Thu, 21 Aug 2025 12:29:43 +0100, Ben Horgan <ben.horgan@xxxxxxx> wrote: > > Hi Marc, > > On 8/17/25 21:21, Marc Zyngier wrote: > > The ARM64_FEATURE_MASK() macro was a hack introduce whilst the > > automatic generation of sysreg encoding was introduced, and was > > too unreliable to be entirely trusted. > > > > We are in a better place now, and we could really do without this > > macro. Get rid of it altogether. > > > > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx> > > --- > > arch/arm64/include/asm/sysreg.h | 3 -- > > arch/arm64/kvm/arm.c | 8 ++-- > > arch/arm64/kvm/sys_regs.c | 40 +++++++++---------- > > tools/arch/arm64/include/asm/sysreg.h | 3 -- > > .../selftests/kvm/arm64/aarch32_id_regs.c | 2 +- > > .../selftests/kvm/arm64/debug-exceptions.c | 12 +++--- > > .../testing/selftests/kvm/arm64/no-vgic-v3.c | 4 +- > > .../selftests/kvm/arm64/page_fault_test.c | 6 +-- > > .../testing/selftests/kvm/arm64/set_id_regs.c | 8 ++-- > > .../selftests/kvm/arm64/vpmu_counter_access.c | 2 +- > > .../selftests/kvm/lib/arm64/processor.c | 6 +-- > > 11 files changed, 44 insertions(+), 50 deletions(-) > > > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > > index d5b5f2ae1afaa..6604fd6f33f45 100644 > > --- a/arch/arm64/include/asm/sysreg.h > > +++ b/arch/arm64/include/asm/sysreg.h > > @@ -1142,9 +1142,6 @@ > > #define ARM64_FEATURE_FIELD_BITS 4 > While you're at it, consider getting rid of ARM64_FEATURE_FIELD_BITS > too. This is only used in the set_id_regs.c selftest. I don't really understand what this test (like most tests) is doing, so I'm not going to touch it. If you figure it out, feel free to send a patch. Thanks, M. -- Jazz isn't dead. It just smells funny.
