Re: [PATCH v9 05/18] x86/apic: Add update_vector() callback for apic drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 26, 2025 at 09:36:56AM +0530, Upadhyay, Neeraj wrote:
> or chip_data_update_vector() as the updates are specific for a new vector
> assignment?

This function assigns a bunch of things to struct apic_chip_data - not only
vector.

If we had to be precise perhaps update_vector_chip_data() or so. Or
chip_data_update_for_vector(). To better describe what the function does.

> Got it. However, I see other static functions in this file using "apic_"
> prefix (in some cases, maybe to differentiate "apic_chip_data" from a
> generic "chip_data" in common kernel/irq/ subys?).

Looks like this file would need cleaning up wrt naming but that's not that
important at the moment I'd say. There are other functions which don't have
the apic_ prefix so it is kinda arbitrary.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux