On Wed, 2025-08-27 at 19:40 -0500, Ira Weiny wrote: > > + .map_writable = true, > > Why is map_writable set? Doesn't this get translated into host_writable? I guess it's normally set only if it's a !KVM_MEM_READONLY slot for private faults memory. But that flag is invalid for gmem. So we should only have map_writable=true cases for tdx. Hypothetically this function should work for non-gmem. I guess since it's exported, a comment could be nice to specify that the memslots are not consulted. There are many MMU details that are not commented though, so it's probably too much given that the struct is right there to look at what kind of fault it is.
