On Thu, 2025-08-28 at 11:50 -0700, Sean Christopherson wrote: > > > > I realize you are just trying to do map->prefault here, but "page" seems > > redundant once you have "prefault" in the name. Why page here vs all the > > other fault handler functions without it? > > kvm_tdp_prefault() feels a bit ambiguous/bare. Many of the fault helpers do > have "page", it's just before the fault part. > > kvm_mmu_finish_page_fault > kvm_handle_page_fault > kvm_tdp_page_fault > direct_page_fault > nonpaging_page_fault > kvm_tdp_mmu_page_fault > > (and probably more) True. > > How about kvm_tdp_page_prefault()? Or kvm_tdp_do_prefault(), but I think I > like kvm_tdp_page_prefault() a little more. kvm_tdp_page_prefault() would be my pick of those.
