Re: [PATCH] vfio: selftests: Fix .gitignore for already tracked files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 28 Aug 2025 18:58:14 +0000
David Matlack <dmatlack@xxxxxxxxxx> wrote:

> Fix the rules in tools/testing/selftests/vfio/.gitignore to not ignore
> some already tracked files (.gitignore, Makefile, lib/libvfio.mk).
> 
> This change should be a no-op, since these files are already tracked by git and
> thus git will not ignore updates to them even though they match the ignore
> rules in the VFIO selftests .gitignore file.
> 
> However, they do generate warnings with W=1, as reported by the kernel test
> robot.
> 
>   $ KBUILD_EXTRA_WARN=1 scripts/misc-check
>   tools/testing/selftests/vfio/.gitignore: warning: ignored by one of the .gitignore files
>   tools/testing/selftests/vfio/Makefile: warning: ignored by one of the .gitignore files
>   tools/testing/selftests/vfio/lib/libvfio.mk: warning: ignored by one of the .gitignore files
> 
> Fix this by explicitly un-ignoring the tracked files.
> 
> Fixes: 292e9ee22b0a ("selftests: Create tools/testing/selftests/vfio")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508280918.rFRyiLEU-lkp@xxxxxxxxx/
> Signed-off-by: David Matlack <dmatlack@xxxxxxxxxx>
> ---
> Note, this is on top of the vfio/next branch so I'm not sure if the hash
> in the fixes tag is guaranteed to be stable. It might be simpler to
> squash this into commit 292e9ee22b0a ("selftests: Create
> tools/testing/selftests/vfio") before sending the pull request to Linus.
> 
>  tools/testing/selftests/vfio/.gitignore | 3 +++
>  1 file changed, 3 insertions(+)

Applied to vfio next branch for v6.18.  Let's consider the commit
hashes sufficiently stable for now.  In the off chance that I need to
back something out, I can fix them.  I think it's useful for the log
to have the fixes separate, as evidenced by being able to reference
Sean's similar fix.  Thanks,

Alex





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux