On Mon, 1 Sept 2025 at 14:26, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote:
>
> kvmppc_load_htab_chunk() is used for migration, thus is not
> a hot path. Use the heap instead of the stack, removing the
> alloca() call.
>
> Reported-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> ---
> target/ppc/kvm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index d145774b09a..937b9ee986d 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -2760,11 +2760,10 @@ int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize, int64_t max_ns)
> int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index,
> uint16_t n_valid, uint16_t n_invalid, Error **errp)
> {
> - struct kvm_get_htab_header *buf;
> size_t chunksize = sizeof(*buf) + n_valid * HASH_PTE_SIZE_64;
> + g_autofree struct kvm_get_htab_header *buf = g_malloc(chunksize);
> ssize_t rc;
>
> - buf = alloca(chunksize);
> buf->index = index;
> buf->n_valid = n_valid;
> buf->n_invalid = n_invalid;
Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
thanks
-- PMM
