Re: [PATCH 2/2] vfio scsi ui: Error-check qio_channel_socket_connect_sync() the same way

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23.07.2025 16:32, Markus Armbruster wrote:
qio_channel_socket_connect_sync() returns 0 on success, and -1 on
failure, with errp set.  Some callers check the return value, and some
check whether errp was set.

For consistency, always check the return value, and always check it's
negative.

Ditto for this one - applying this for qemu-stable (10.0 & 10.1).
It doesn't hurt, and the code in longer-supported branches will
be less different from the master branch, making future changes,
if any, easier to pick up (there were multiple fixes in this area
recently).

Please let me know if I shouldn't :)

Thanks,

/mjt




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux