Re: [PATCH] LoongArch: KVM: remove unused returns.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2025/9/4 下午4:20, Huacai Chen wrote:
On Thu, Sep 4, 2025 at 4:14 PM cuitao <cuitao@xxxxxxxxxx> wrote:

Thanks for the review.

My initial idea was to remove the switch-case structure.
However, after checking the case value KVM_FEATURE_STEAL_TIME,
I found there are 13 parallel definitions—and it is unclear when
this part of the development will be completed later. Therefore,
I temporarily retained the switch-case structure.

Now, I have updated the patch according to your suggestion:
- Replaced `switch` with `if` since there is only one case.
- Removed the redundant semicolon after the block.

Please see the updated patch below.
It has been applied, don't make useless effort.
https://github.com/chenhuacai/linux/commit/f5d35375a6546bcc5d0993e3a48cdbc3a7217544
I think that it is unnecessary to replace `switch` with `if` here:)

One thing is that the change is big for such thing, and also there may be new case condition in future, just maybe.

Regards
Bibo Mao

Huacai


Thanks,
Tiezhu





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux