On Wed, Sep 10, 2025 at 09:10:06AM -0700, Dave Hansen wrote: > On 9/10/25 09:06, Kiryl Shutsemau wrote: > >> struct tdx_vp { > >> /* TDVP root page */ > >> struct page *tdvpr_page; > >> + /* precalculated page_to_phys(tdvpr_page) for use in noinstr code */ > >> + phys_addr_t tdvpr_pa; > > Missing newline above the new field? > > I was actually trying to group the two fields together that are aliases > for the same logical thing. > > Is that problematic? No. Just looks odd to me. But I see 'struct tdx_td' also uses similar style. -- Kiryl Shutsemau / Kirill A. Shutemov