On Tue, Sep 09, 2025 at 10:55:18AM +0000, Huang, Kai wrote: > How about we just initialize r to -EINVAL once before tdx_get_sysinfo() so > that all 'r = -EINVAL;' can be removed? I think in this way the code > would be simpler (see below diff [*])? > > The "Fixes" tag would be hard to identify, though, because the diff > touches the code introduced multiple commits. But I am not sure whether > this is a true issue since AFAICT we can use multiple "Fixes" tags. Your diff looks fine to me, however my personal preference would be to do the fix first then clean-up :) Regards, Tony