On Tue, 5 Aug 2025 12:15:58 -0600 Alex Williamson <alex.williamson@xxxxxxxxxx> wrote: > On Tue, 5 Aug 2025 07:56:43 -0600 > Alex Williamson <alex.williamson@xxxxxxxxxx> wrote: > > > On Tue, 5 Aug 2025 15:27:35 +0200 > > David Hildenbrand <david@xxxxxxxxxx> wrote: > > > > > On 05.08.25 03:24, Alex Williamson wrote: > > > > Objections were raised to adding this helper to common code with only a > > > > single user and dubious generalism. Pull it back into subsystem code. > > > > > > > > Link: https://lore.kernel.org/all/CAHk-=whhYRMS7Xc9k_JBdrGvp++JLmU0T2xXEgn046hWrj7q8Q@xxxxxxxxxxxxxx/ > > > > Cc: David Hildenbrand <david@xxxxxxxxxx> > > > > Cc: Jason Gunthorpe <jgg@xxxxxxxxxx> > > > > Cc: Li Zhe <lizhe.67@xxxxxxxxxxxxx> > > > > Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx> > > > > --- > > > > > > So, we might have a version that Linus should be happy with, that we > > > could likely place in mm/util.c. > > > > > > Alex, how would you want to proceed with that? > > > > Still reading the thread overnight, but if there's a better solution > > that Linus won't balk at then let's do it. Thanks, > > How soon were you thinking of sending an alternate proposal? I don't > want to make this any messier, but this patch gives us some breathing > room for the merge window. Thanks, After chatting with David off-list, I think we agree that just moving this nth_page code into vfio is likely not the best solution since there does seem to potentially be some agreement for an mm/util.c helper. However, it's too late for v6.17, so I've dropped this optimization from my next branch with the expectation that we'll fix it properly and re-queue it fro v6.18. Thanks, Alex
