Re: [kvm-unit-tests PATCH v4 2/5] x86: fix APs with APIC ID more that 255 not showing in id_map

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 25, 2025 at 11:54:26AM +0200, Igor Mammedov wrote:
> save_id() is called too early and uses xapic ops, which is fine
> up to 2566 cpus.
> However with that any CPU with APIC ID more than 255 will set
> wrong bit in online_cpus (since xapic ops only handle 8bit IDs,
> thus losing all higher bit x2apic might have).
> As result CPUs with id higher than 255 are not registered
> (they will trumple over elements in range 0-255 instead).
> 
> To fix it move save_id() after the point where APs have
> switched to x2apic ops, to get non-truncated ID.
> 
> Signed-off-by: Igor Mammedov <imammedo@xxxxxxxxxx>

Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>

-- 
Peter Xu





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux