hi, Sean, is this understanding correct? > IMO, unless there is any objection to [1], it's un-necessary to > maintain kvm_gmem_populate for any arch (even for SNP). All the > initial memory population logic needs is the stable pfn for a given > gfn, which ideally should be available using the standard mechanisms > such as EPT/NPT page table walk within a read KVM mmu lock (This patch > already demonstrates it to be working). > > It will be hard to clean-up this logic once we have all the > architectures using this path. > > [1] https://lore.kernel.org/lkml/CAGtprH8+x5Z=tPz=NcrQM6Dor2AYBu3jiZdo+Lg4NqAk0pUJ3w@xxxxxxxxxxxxxx/ IIUC, the suggestion in the link is to abandon kvm_gmem_populate(). For TDX, it means adopting the approach in this RFC patch, right? > > [3] https://lore.kernel.org/lkml/20250613005400.3694904-2-michael.roth@xxxxxxx,