Re: [PATCH 3/3] KVM: PPC: use for_each_set_bit() in IRQ_check()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17. 07. 25, 21:24, Yury Norov wrote:
From: Yury Norov (NVIDIA) <yury.norov@xxxxxxxxx>

The function opencodes for_each_set_bit() macro.

Signed-off-by: Yury Norov (NVIDIA) <yury.norov@xxxxxxxxx>
---
  arch/powerpc/kvm/mpic.c | 8 ++------
  1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c
index 23e9c2bd9f27..ae68b213f0f9 100644
--- a/arch/powerpc/kvm/mpic.c
+++ b/arch/powerpc/kvm/mpic.c
@@ -290,15 +290,11 @@ static inline void IRQ_resetbit(struct irq_queue *q, int n_IRQ)
static void IRQ_check(struct openpic *opp, struct irq_queue *q)
  {
-	int irq = -1;
+	int irq;

Can be unsigned now, right?

  	int next = -1;
  	int priority = -1;
- for (;;) {
-		irq = find_next_bit(q->queue, opp->max_irq, irq + 1);
-		if (irq == opp->max_irq)
-			break;
-
+	for_each_set_bit(irq, q->queue, opp->max_irq) {
  		pr_debug("IRQ_check: irq %d set ivpr_pr=%d pr=%d\n",
  			irq, IVPR_PRIORITY(opp->src[irq].ivpr), priority);

thanks,
--
js
suse labs





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux