On Thu, Jul 17, 2025, Fuad Tabba wrote: > From: Ackerley Tng <ackerleytng@xxxxxxxxxx> > > Generalize the private_max_mapping_level x86 operation to > max_mapping_level. No, this is wrong. The "private" part can be dropped, but it must not be a fully generic helper, it needs to be limited to gmem. For mappings that follow the primary MMU, the primary MMU is the single source of truth. It's not just a nitpick, I got royally confused by the name when looking at the next patch. s/private_max_mapping_level/gmem_max_mapping_level and we're good.