On 16.07.25 22:36, John Allen wrote: > On Mon, Jul 07, 2025 at 09:32:37AM +0800, Chao Gao wrote: >> On Mon, Jul 07, 2025 at 12:51:14AM +0800, Xiaoyao Li wrote: >>> Hi Chao, >>> >>> On 7/4/2025 4:49 PM, Chao Gao wrote: >>>> Tests: >>>> ====================== >>>> This series passed basic CET user shadow stack test and kernel IBT test in L1 >>>> and L2 guest. >>>> The patch series_has_ impact to existing vmx test cases in KVM-unit-tests,the >>>> failures have been fixed here[1]. >>>> One new selftest app[2] is introduced for testing CET MSRs accessibilities. >>>> >>>> Note, this series hasn't been tested on AMD platform yet. >>>> >>>> To run user SHSTK test and kernel IBT test in guest, an CET capable platform >>>> is required, e.g., Sapphire Rapids server, and follow below steps to build >>>> the binaries: >>>> >>>> 1. Host kernel: Apply this series to mainline kernel (>= v6.6) and build. >>>> >>>> 2. Guest kernel: Pull kernel (>= v6.6), opt-in CONFIG_X86_KERNEL_IBT >>>> and CONFIG_X86_USER_SHADOW_STACK options. Build with CET enabled gcc versions >>>> (>= 8.5.0). >>>> >>>> 3. Apply CET QEMU patches[3] before build mainline QEMU. >>> >>> You forgot to provide the links of [1][2][3]. >> >> Oops, thanks for catching this. >> >> Here are the links: >> >> [1]: KVM-unit-tests fixup: >> https://lore.kernel.org/all/20230913235006.74172-1-weijiang.yang@xxxxxxxxx/ >> [2]: Selftest for CET MSRs: >> https://lore.kernel.org/all/20230914064201.85605-1-weijiang.yang@xxxxxxxxx/ >> [3]: QEMU patch: >> https://lore.kernel.org/all/20230720111445.99509-1-weijiang.yang@xxxxxxxxx/ >> >> Please note that [1] has already been merged. And [3] is an older version of >> CET for QEMU; I plan to post a new version for QEMU after the KVM series is >> merged. > > Do you happen to have a branch with the in-progress qemu patches you are > testing with? I'm working on testing on AMD and I'm having issues > getting this old version of the series to work properly. For me the old patches worked by changing the #define of MSR_KVM_GUEST_SSP from 0x4b564d09 to 0x4b564dff -- on top of QEMU 9.0.1, that is. Thanks, Mathias
