On 7/16/25 4:25 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20250715: > on ARCH=um SUBARCH=x86_64: ../drivers/vfio/cdx/intr.c: In function ‘vfio_cdx_msi_enable’: ../drivers/vfio/cdx/intr.c:41:15: error: implicit declaration of function ‘msi_domain_alloc_irqs’; did you mean ‘msi_domain_get_virq’? [-Wimplicit-function-declaration] 41 | ret = msi_domain_alloc_irqs(dev, MSI_DEFAULT_DOMAIN, nvec); | ^~~~~~~~~~~~~~~~~~~~~ | msi_domain_get_virq ../drivers/vfio/cdx/intr.c: In function ‘vfio_cdx_msi_disable’: ../drivers/vfio/cdx/intr.c:135:9: error: implicit declaration of function ‘msi_domain_free_irqs_all’ [-Wimplicit-function-declaration] 135 | msi_domain_free_irqs_all(dev, MSI_DEFAULT_DOMAIN); | ^~~~~~~~~~~~~~~~~~~~~~~~ Those missing functions are provided by CONFIG_GENERIC_MSI_IRQ (which is not set). Should VFIO_CDX select GENERIC_MSI_IRQ or just not build on ARCH=um? -- ~Randy