On Fri, Jun 06, 2025 at 04:56:15PM -0700, Vipin Sharma wrote: > Add logic in Makefile.kvm to auto generate default test files for KVM > Selftests Runner. Preserve the hierarchy of test executables for > autogenerated files. > > Autogeneration of default test files guards against missing these files > for new tests cases or rename of existing ones. These autogenerated > files will be checked in so that during git-diff one can easily identify > if the existing test files for the same test binary also needs an > update. It also add new tests automatically in the default coverage. I'm not sure I'm sold on the merits of committing these to the tree. My preference would be to prioritize signal to noise and just commit the 'interesting' test configurations and generate the defaults from $(TEST_PROGS) somewhere they're gitignored. There's no amount of foolproofing that'll prevent folks from renaming a test name w/o updating the 'interesting' test configurations that depend upon it. Seriously -- I'm sure I'll manage to break it at least once :) On top of that, there's a lot of selftests that take no arguments. Not sure what we gain having a duplicated definition for these ones outside of $(TEST_PROGS). Thanks, Oliver
