> From: Mehta, Sohil <sohil.mehta@xxxxxxxxx> > [...] > >> Platform NMI handlers have a single handler registered per type. They > >> don't > > > > From the current NMI code point of view [1] or [2], a type of platform > > NMI handler may have multiple handlers registered. > > > > [1] > > https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > /tree/arch/x86/kernel/nmi.c#n199 [2] > > https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > /tree/arch/x86/kernel/nmi.c#n201 > > > > We have warnings that should flag any time multiple handlers are registered > for SERR or IO_CHK: > > /* > * Indicate if there are multiple registrations on the > * internal NMI handler call chains (SERR and IO_CHECK). > */ > WARN_ON_ONCE(type == NMI_SERR && !list_empty(&desc->head)); > WARN_ON_ONCE(type == NMI_IO_CHECK && !list_empty(&desc- > >head)); > The warning doesn't imply that it must be a single NMI handler. Otherwise, why not use a single NMI callback pointer per platform NMI type for registration in the current NMI code? I just don't want your comments or commit messages to mismatch the current code as it stands. -Qiuxu
