> From: Brett Creeley <brett.creeley@xxxxxxx>
> Sent: Thursday, July 3, 2025 12:38 AM
>
> When CONFIG_IOMMUFD is enabled and a device is bound to the
> pds_vfio_pci
> driver, the following WARN_ON() trace is seen and probe fails:
>
> WARNING: CPU: 0 PID: 5040 at drivers/vfio/vfio_main.c:317
> __vfio_register_dev+0x130/0x140 [vfio]
> <...>
> pds_vfio_pci 0000:08:00.1: probe with driver pds_vfio_pci failed with error -
> 22
>
> This is because the driver's vfio_device_ops.detach_ioas isn't set.
>
> Fix this by using the generic vfio_iommufd_physical_detach_ioas
> function.
>
> Fixes: 38fe3975b4c2 ("vfio/pds: Initial support for pds VFIO driver")
> Signed-off-by: Brett Creeley <brett.creeley@xxxxxxx>
It's a surprise to see it caught so late...
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
