On 1/7/25 17:50, Peter Maydell wrote:
On Mon, 23 Jun 2025 at 13:20, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote:
Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx>
Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>
---
python/qemu/utils/__init__.py | 2 +-
python/qemu/utils/accel.py | 8 ++++++++
tests/functional/qemu_test/testcase.py | 6 ++++--
3 files changed, 13 insertions(+), 3 deletions(-)
This seems to trigger errors in the check-python-minreqs job:
https://gitlab.com/pm215/qemu/-/jobs/10529051338
Log file "stdout" content for test "01-tests/flake8.sh" (FAIL):
qemu/utils/__init__.py:26:1: F401 '.accel.hvf_available' imported but unused
qemu/utils/accel.py:86:1: E302 expected 2 blank lines, found 1
Log file "stderr" content for test "01-tests/flake8.sh" (FAIL):
Log file "stdout" content for test "04-tests/isort.sh" (FAIL):
ERROR: /builds/pm215/qemu/python/qemu/utils/__init__.py Imports are
incorrectly sorted and/or formatted.
I'll see if I can fix this up locally. (The missing blank line
is easy; I think probably hvf_available needs to be in the
__all__ = () list in __init__.py like kvm_available and
tcg_available. Not sure about the incorrectly-sorted warning.)
I neglected to rebuild the Python package, sorry...
Don't worry dropping this patch and the following.