On Wed, 2025-06-25 at 10:58 -0700, Dave Hansen wrote:
> > --- a/arch/x86/kvm/vmx/tdx.c
> > +++ b/arch/x86/kvm/vmx/tdx.c
> > @@ -202,12 +202,6 @@ static DEFINE_MUTEX(tdx_lock);
> >
> > static atomic_t nr_configured_hkid;
> >
> > -static bool tdx_operand_busy(u64 err)
> > -{
> > - return (err & TDX_SEAMCALL_STATUS_MASK) == TDX_OPERAND_BUSY;
> > -}
> > -
> > -
>
> Isaku, this one was yours (along with the whitespace damage). What do
> you think of this patch?
I think this actually got added by Paolo, suggested by Binbin. I like these
added helpers a lot. KVM code is often open coded for bitwise stuff, but since
Paolo added tdx_operand_busy(), I like the idea of following the pattern more
broadly. I'm on the fence about tdx_status() though.
