Re: [PATCH] KVM: guest_memfd: Remove redundant kvm_gmem_getattr implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/2/2025 7:23 PM, Shivank Garg wrote:
Remove the redundant kvm_gmem_getattr() implementation that simply calls
generic_fillattr() without any special handling. The VFS layer
(vfs_getattr_nosec()) will call generic_fillattr() by default when no
custom getattr operation is provided in the inode_operations structure.

This is a cleanup with no functional change.

Signed-off-by: Shivank Garg <shivankg@xxxxxxx>

Reviewed-by: Pankaj Gupta <pankaj.gupta@xxxxxxx>

---
  virt/kvm/guest_memfd.c | 11 -----------
  1 file changed, 11 deletions(-)

diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c
index b2aa6bf24d3a..7d85cc33c0bb 100644
--- a/virt/kvm/guest_memfd.c
+++ b/virt/kvm/guest_memfd.c
@@ -382,23 +382,12 @@ static const struct address_space_operations kvm_gmem_aops = {
  #endif
  };
-static int kvm_gmem_getattr(struct mnt_idmap *idmap, const struct path *path,
-			    struct kstat *stat, u32 request_mask,
-			    unsigned int query_flags)
-{
-	struct inode *inode = path->dentry->d_inode;
-
-	generic_fillattr(idmap, request_mask, inode, stat);
-	return 0;
-}
-
  static int kvm_gmem_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
  			    struct iattr *attr)
  {
  	return -EINVAL;
  }
  static const struct inode_operations kvm_gmem_iops = {
-	.getattr	= kvm_gmem_getattr,
  	.setattr	= kvm_gmem_setattr,
  };





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux