On 6/24/2025 4:07 PM, Huang, Kai wrote:
> On Tue, 2025-06-10 at 23:24 +0530, Neeraj Upadhyay wrote:
>> Use 'regs' as a contiguous linear bitmap in apic_{set|
> ^
> double whitespace here
>
Will fix.
>> clear|test}_vector() while doing bitwise operations.
>> This makes the code simpler by eliminating the need to
>> determine the offset of the 32-bit register and the vector
>> bit location within that register prior to performing
>> bitwise operations.
>>
>> This change results in slight increase in generated code
>> size for gcc-14.2.
>
> Seems the text wrap here is different from other patches, i.e., the
> 'textwidth' seems much smaller.
>
Will fix it.
>>
>> - Without change
>>
>> apic_set_vector:
>
> Perhaps add a blank line here to make it easier to read (also consistent
> with below).
>
Ack
Thanks for the review!
- Neeraj
