On Wed, 2025-06-18 at 15:08 +0300, Hunter, Adrian wrote:
> Skip clearing a private page if it is marked as poisoned.
>
> The machine check architecture may have the capability to recover from
^
"to recover" -> "to allow the kernel to recover"?
> memory corruption in SEAM non-root (i.e. TDX VM guest) mode. In that
> case the page is marked as poisoned, and the TDX Module puts the TDX VM
"marked as poisoned" -> "marked as poisoned in the kernel"? Since next half
of this sentence immediately talks about TDX module behaviour.
> into a FATAL error state where the only operation permitted is to tear it
> down.
>
> During tear down, reclaimed pages are cleared which, in some cases, helps
^
Double writespace in middle of sentence.
> to avoid integrity violation or TD bit mismatch detection when later being
> read using a shared HKID.
>
> However a poisoned page will never be allocated again, so clearing is not
> necessary, and in any case poisoned pages should not be touched.
>
> Note that while it is possible that memory corruption arises from integrity
> violation which could be cleared by MOVDIR64B, that is not necessarily the
> cause of the machine check.
>
> Suggested-by: Kai Huang <kai.huang@xxxxxxxxx>
> Fixes: 8d032b683c299 ("KVM: TDX: create/destroy VM structure")
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
With comments from Xiaoyao/Dave fixed,
Reviewed-by: Kai Huang <kai.huang@xxxxxxxxx>
