On 6/17/2025 4:10 PM, Sohil Mehta wrote:
Ah, and now I see that DR6_RESERVED is an existing #define in a uAPI header (Xin
said there were a few, but I somehow missed them earlier). Maybe just leave that
thing alone, but update the comment to state that it's a historical wart? And
then put DR6_ACTIVE_LOW and other macros in arch/x86/include/asm/debugreg.h?
Yeah, that's unfortunate. Updating the comment seems the best we do for now.
It's a mess, and I don't think I can just remove DR6_RESERVED.
But the value 0xFFFF0FF0 no longer makes sense on newer CPUs, so maybe
it won't cause any real problem?