On Thu, Jun 12, 2025, Kai Huang wrote: > On Wed, 2025-06-11 at 14:35 -0700, Sean Christopherson wrote: > > Move the PIT ioctl helpers to i8254.c, i.e. to the file that implements > > PIT emulation. Eliminating PIT code in x86.c will allow adding a Kconfig > > to control support for in-kernel I/O APIC, PIC, and PIT emulation with > > minimal #ifdefs. > > And it matches the other (existing) ioctl helpers which are under > CONFIG_KVM_HYPERV [*] and CONFIG_KVM_XEN too. > > [*]: The kvm_ioctl_get_supported_hv_cpuid() seems to be the only one that > still remains in kvm/x86.c but not in kvm/hyperv.c. Ooh, yeah, that'd be a good one to move out of x86.c.