On Tue, Jun 10, 2025, Dapeng Mi wrote: > On 5/30/2025 6:19 AM, Sean Christopherson wrote: > > +#define X86_FEATURE_SVM X86_CPU_FEATURE(0x80000001, 0, ECX, 2) > > +#define X86_FEATURE_PERFCTR_CORE X86_CPU_FEATURE(0x80000001, 0, ECX, 23) > > +#define X86_FEATURE_NX X86_CPU_FEATURE(0x80000001, 0, EDX, 20) > > +#define X86_FEATURE_GBPAGES X86_CPU_FEATURE(0x80000001, 0, EDX, 26) > > +#define X86_FEATURE_RDTSCP X86_CPU_FEATURE(0x80000001, 0, EDX, 27) > > +#define X86_FEATURE_LM X86_CPU_FEATURE(0x80000001, 0, EDX, 29) > > +#define X86_FEATURE_RDPRU X86_CPU_FEATURE(0x80000008, 0, EBX, 4) > > +#define X86_FEATURE_AMD_IBPB X86_CPU_FEATURE(0x80000008, 0, EBX, 12) > > +#define X86_FEATURE_NPT X86_CPU_FEATURE(0x8000000A, 0, EDX, 0) > > +#define X86_FEATURE_LBRV X86_CPU_FEATURE(0x8000000A, 0, EDX, 1) > > +#define X86_FEATURE_NRIPS X86_CPU_FEATURE(0x8000000A, 0, EDX, 3) > > +#define X86_FEATURE_TSCRATEMSR X86_CPU_FEATURE(0x8000000A, 0, EDX, 4) > > +#define X86_FEATURE_PAUSEFILTER X86_CPU_FEATURE(0x8000000A, 0, EDX, 10) > > +#define X86_FEATURE_PFTHRESHOLD X86_CPU_FEATURE(0x8000000A, 0, EDX, 12) > > +#define X86_FEATURE_VGIF X86_CPU_FEATURE(0x8000000A, 0, EDX, 16) > > +#define X86_FEATURE_VNMI X86_CPU_FEATURE(0x8000000A, 0, EDX, 25) > > The code looks good to me except the indent style (mixed tab and space). > Although it's not introduced by this patch, we'd better make them identical > by this chance. Agreed, that is weird. I didn't notice it in the code, but looking at this diff again, it really stands out.
